Extend support for more features of VCell expressions#33
Merged
CodeByDrescher merged 8 commits intomainfrom Mar 17, 2026
Merged
Extend support for more features of VCell expressions#33CodeByDrescher merged 8 commits intomainfrom
CodeByDrescher merged 8 commits intomainfrom
Conversation
jcschaff
requested changes
Mar 17, 2026
Member
jcschaff
left a comment
jcschaff
left a comment
There was a problem hiding this comment.
please augment test_expressions.py by verifying the computed result from numexpr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyVCell uses zarr for handling its data, and in python that comes with two core limitations:
NumExpr's notation. VCell now supports that.zarrdoes not support JSON-serializing booleans.This PR brings in the changes needed to rectify this, plus also adds a test to prevent regression.